BEP-439: Implement EIP-2537: Precompile for BLS12-381 curve operations#2719
Closed
buddh0 wants to merge 3 commits intobnb-chain:developfrom
buddh0:BEP_439_bls_precompiles
Closed
BEP-439: Implement EIP-2537: Precompile for BLS12-381 curve operations#2719buddh0 wants to merge 3 commits intobnb-chain:developfrom buddh0:BEP_439_bls_precompiles
buddh0 wants to merge 3 commits intobnb-chain:developfrom
buddh0:BEP_439_bls_precompiles
Conversation
…#29441) This PR updates the bls contracts from our internal implementation which is an unmaintained fork of the kilic library to the gnark-crypto library that is actively maintained by consensys. It also updates the gas-costs according to the EIP
Contributor
Author
|
lint error for commits from upstream, so ignore |
Contributor
Author
|
please reserve all commits when merging into develop! |
buddh0
changed the title
buddh0
changed the title
Contributor
Author
|
the implement is aligned with pectrac-devnet-3, |
Contributor
Author
|
convert to draft, for the gas cost will change |
Contributor
What is the reason for this? :) |
Contributor
Author
|
has been upstreamed in PR #2761 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BEP-439: Implement EIP-2537: Precompile for BLS12-381 curve operations
Rationale
tell us why we need these changes...
Example
how to verify the code implement? two steps:
bsc/core/vm/testdata/precompilesare the same withgo-ethereum/core/vm/testdata/precompilesat the latest commitall pass
Changes
the first two commitss are picked from upstream
the third commit refers to ethereum/go-ethereum#29552